KEP-1645: make endpointslices optional, but structure required if they exist #3950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lauralorenz
commented
Apr 10, 2023
lauralorenz
commented
- One-line PR description: KEP-1645: make endpointslices optional, but structure required if they exist
- Issue link: Multi-Cluster Services API #1645
- Other comments: Moves section on EndpointSlices lower and add rationale on how they are optional, but required to conform to a specific format if they exist. This is following SIG-MC discussion on 3/21; see also the proposal doc here.
Signed-off-by: lauralorenz <[email protected]>
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
sig/multicluster
lauralorenz
commented
Apr 10, 2023
Comment on lines
857
to
871
| ### EndpointSlices | ||
|
|
||
| _Optional to create, but specification defined if present._ | ||
|
|
||
| #### EndpointSlice | ||
| The specific mechanism by which the `mcs-controller` maintains references to the | ||
| individual backends for an aggregated service is an implementation detail not | ||
| fully prescribed by this specification. Implementations may depend on a higher | ||
| level (possibly vendor-specific) API, offload to a load balancer or xDS server | ||
| (like Envoy), or use Kubernetes networking APIs. | ||
|
|
||
| If an implementation does create `discovery.k8s.io/v1 EndpointSlice`s, they must | ||
| conform to the following structure. This structure was originally required as | ||
| part of this specification in alpha, and are the structure on which other | ||
| SIG-endorsed reference implementations and tooling, like the [CoreDNS | ||
| multicluster plugin](https://github.com/coredns/multicluster/), depend. |
There was a problem hiding this comment.
FYI this section is the only new words; everything else is just moved.
robscott
reviewed
Apr 10, 2023
There was a problem hiding this comment.
Thanks @lauralorenz! I agree with this direction but have a few nits.
keps/sig-multicluster/1645-multi-cluster-services-api/README.md
Outdated
Show resolved
Hide resolved
keps/sig-multicluster/1645-multi-cluster-services-api/README.md
Outdated
Show resolved
Hide resolved
keps/sig-multicluster/1645-multi-cluster-services-api/README.md
Outdated
Show resolved
Hide resolved
Signed-off-by: lauralorenz <[email protected]>
🙏 thank you, addressed all in 7771e7a |
Signed-off-by: lauralorenz <[email protected]>
|
/cc jeremyot |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
|
/remove-lifecycle stale |
k8s-ci-robot
removed
the
lifecycle/stale
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JeremyOT, lauralorenz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.